Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[KAT-1726] Consolidate RDG inspection routines into one place #557

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

[KAT-1726] Consolidate RDG inspection routines into one place #557

wants to merge 1 commit into from

Conversation

GioLomia
Copy link
Contributor

@GioLomia GioLomia commented Sep 22, 2021 •
edited
Loading

Functionality for inspecting an RDG is scattered throughout the codebase.

There are

  • various test utilities under libtsuba-fs/test/tsuba_*
  • deprecated tools under external/katana/tools/graph-remap and tools/graph-info
  • deprecated tools under tools/dist-graph-convert and tools/graph-info
  • ad hoc scripts

We also have import/conversion executables under

  • tools/import
  • external/katana/tools/graph-convert and external/katana/tools/graph-convert (graph-convert-properties)

Leaving aside the import/conversion executables for now, there really should be one place for all RDG inspection and manipulation routines (ls, copy, du, etc.).

The core logic should be written in one place (e.g., libtsuba) and then exposed either as an executable or via python bindings (probably both).

@GioLomia GioLomia self-assigned this Sep 22, 2021
@ddn0 ddn0 marked this pull request as draft September 22, 2021 17:09
amberhassaan
amberhassaan reviewed Oct 13, 2021
View reviewed changes
Copy link
Contributor

@amberhassaan amberhassaan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial comments. Will take a more detailed look later.

libtsuba/include/tsuba/RDGInspection.h

void
doSummary(Graph& graph) {
std::cout << "NumNodes: " << graph.size() << "\n";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use fmt::print everywhere and don't use std::cout and don't #include <iostream>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amberhassaan amberhassaan amberhassaan left review comments

@ddn0 ddn0 Awaiting requested review from ddn0

At least 1 approving review is required to merge this pull request.

Assignees

@GioLomia GioLomia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GioLomia @amberhassaan